[release/9.0] Caching SERedis critical bugfix; defer HC metadata detection because of DI cycle #60916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
captainsafia,
halter73 and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
mgravell
added
Servicing-consider
1 task
captainsafia
approved these changes
Mar 13, 2025
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
(CI fail is unrelated but vexing) |
danmoseley
reviewed
Apr 7, 2025
danmoseley
added
Servicing-approved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Mac failures are an issue w/ the dotnetbuilds CDN - I think #60353 will unblock |
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
(nods with thanks towards @wtgodbe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60915 to release/9.0
/cc @mgravell
Caching SERedis critical bugfix; defer HC metadata detection because of DI cycle
Fix DI loop in metadata discovery - interaction between two components
Description
Unfortunately because the two components are in different repos, a fake was used to "prove" the setup here; this fake did not fully reproduce the DI demands, hance a cyclic interaction was not discovered. The test has been updated to reflect the real DI setup, and the code reworked.
Fixes #60894
Customer Impact
Attempts to use
AddHybridCache()andAddStackExchangeRedis()together can cause DI to loop infinitely or until stack-overflow.Regression?
Risk
Change is simple DI restructure only; no complex logic post construction, which is validated in tests.
Verification
Packaging changes reviewed?
When servicing release/2.1